Design comparison
Solution retrospective
Hello,
I decided to go with pseudo-elements for the little icons svgs, and I went crazy trying to figure out, how to align them vertically with their corresponding text. Turns out on the pseudo-element you just have to set the line-height to the same value as the text font-size.
Feel free if you have any suggestions, I'd be happy to hear it/them.
Thank you :)
Community feedback
- @AdrianoEscarabotePosted about 2 years ago
Hi Aatypic, how are you?
I really liked the result of your project, but I have some tips that I think you will like:
1- Every page should have one main landmark
<main>. So replace the div that wraps the whole content with<main>to improve the accessibility. click here2- All page content should be contained by landmarks, you can understand better by clicking here: click here
We have to make sure that all content is contained in a reference region, designated with HTML5 reference elements or ARIA reference regions.
Example:
native HTML5 reference elements:
<body> <header>This is the header</header> <nav>This is the nav</nav> <main>This is the main</main> <footer>This is the footer</footer> </body>ARIA best practices call for using native HTML5 reference elements instead of ARIA functions whenever possible, but the markup in the following example works:
<body> <div role="banner">This is the header</div> <div role="navigation">This is the nav</div> <div role="main">This is the main</div> <div role="contentinfo">This is the footer</div> </body>It is a best practice to contain all content, except skip links, in distinct regions such as header, navigation, main, and footer.
Link to read more about: click here
2- Why it Matters
Navigating the web page is far simpler for screen reader users if all of the content splits between one or more high-level sections. Content outside of these sections is difficult to find, and its purpose may be unclear.
HTML has historically lacked some key semantic markers, such as the ability to designate sections of the page as the header, navigation, main content, and footer. Using both HTML5 elements and ARIA landmarks in the same element is considered a best practice, but the future will favor HTML regions as browser support increases.
Rule Description
It is a best practice to ensure that there is only one main landmark to navigate to the primary content of the page and that if the page contains iframe elements, each should either contain no landmarks, or just a single landmark.
Link to read more about: click here
The rest is great!!
Hope it helps...👍
1@AatypicPosted about 2 years ago@AdrianoEscarabote Hello and thanks for your feedback.
I see where you want to go and I understand the importance of HTML semantic.
But I'm not sure I agree with using <main> for the card because I don't think it is going to be the main element on a page. It is only a component. Imagining it to be like this for example:
<body> ... <main> <section> </section> <section> <div class="card"> </div> </section> ... </main> </body>But yes on a bigger page with more elements or a real project, I would see it.
1@AdrianoEscarabotePosted about 2 years ago@Aatypic I agree with you, but for example, in your project, the card being inside the
maintag is relevant because we have a content under it, so that the screenreader starts reading the main content, which in this case is the card, we have to put it inside themaintag, and the other content inside the footer tag.Marked as helpful1
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord