Design comparison
Solution retrospective
This exercise was similar to the qr code challenge, but I'm trying to get faster at figuring out the layout. Still took me about 1.5 hours.
Community feedback
- @HassiaiPosted over 1 year ago
Add the alt attribute
alt=" "
to the img tag and give it a value to fix the error issue. The value of the alt attribute is the description of the image. For decorative images like icons, there is no need to give it an alt value, for more on alt attribute Click here.To center .card on the page using flexbox only instead of flexbox and margin, add align-items: center and min-height: 100vh to the body and remove the margin value in .card.
Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here
For a responsive content, replace the width in .card with max-width.
You forgot to add the hover effect to your design
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
Marked as helpful0@shafferj8Posted over 1 year ago@Hassiai Thanks and I appreciate the comments. I'll update my code with your suggestions.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord