Design comparison
Solution retrospective
Hello community, Today I would like to share with you this NFT card Component Challenge. I am really open to read your comments.
** Thank you in advance.**
Community feedback
- @HassiaiPosted over 1 year ago
Every html must have <h1> to make it accessible. Always begin the heading of the html with <h1> tag wrap the sub-heading of <h1> in <h2> tag, wrap the sub-heading of <h2> in <h3> this continues until <h6>, never skip a level of a heading.
There is no need to give the body a width, to center .card on the page using flexbox, replace the height in the body with
min-height: 100vh
.Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here and here
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
Marked as helpful2@SparrowHawkEyePosted over 1 year ago- As it just a component that's why I didn't use any <h1> tag here.
- Thanks for the body width and min-height idea.
- I will look forward to it for margin and padding units @Hassiai
Thanks, a lot. 😊
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord