Design comparison
Community feedback
- @VCaramesPosted about 2 years ago
Hey @roricrimson, some suggestions to improve you code:
- Your HTML Code has no structure. To better structure your content and make it a lot clearer, you want to implement Semantic HTML.
Why use Semantic HTML?
- Accessibility: Semantic HTML makes webpages accessible for mobile devices and for people with disabilities as well. This is because screen readers and browsers are able to interpret the code better.
- SEO: It improves the website SEO, or Search Engine Optimization, which is the process of increasing the number of people that visit your webpage. With better SEO, search engines are better able to identify the content of your website and weight the most important content appropriately.
- Easy to Understand: Semantic HTML also makes the website’s source code easier to read for other web developers.
More Info
https://developer.mozilla.org/en-US/docs/Learn/HTML/Introduction_to_HTML/Document_and_website_structure
https://www.freecodecamp.org/news/semantic-html5-elements/
https://dev.to/poulamic/writing-semantic-html-3436
-
The Alt Tag for the NFT image shouldn't be blank. The NFT image serves a purpose to this card. You want to describe what the image is; they need to be readable. Assume you’re describing the image/icon to someone.
-
You want to wrap your "NFT image", "Equilibrium #3429" and "Jules Wyvern" in anchor tags <a>. This is because this are meant to be links that lead the user to another part of a site.
-
You didn't apply any of the hover effects to the image and links.
-
The only heading in this card is the "Equilibrium #3429". Everything else would wrapped in a Paragraph Element.
-
You want to create an external file for you CSS Code.
Happy Coding!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord