Submitted almost 2 years ago
NFT card component using semantic HTML5 markup and CSS Flexbox
@michel-moreira
Design comparison
SolutionDesign
Solution retrospective
Help me to improve the solution code with your feedback!
- Is the code well-structured and readable?
- Do you have any suggestion to have a write a code more professional?
- Any tip of a tool that i can use to simplify it?
Community feedback
- @superpooperxxxPosted almost 2 years ago
Hi, good job on making this🔥 UI looks awesome
Suggestions about code structure and readablity⬇️
- Split tags that have 3+ attributes in multiple lines. That would look more professional.
✅ <img src="src/images/image-equilibrium.jpg" alt="Equilibrium NFT" class="image" >
- Improve your class naming. When you want to name a class like this class="duration", ask your self a question: Can I potentially name something else later in the project "duration". Get used to name classes appropriately, I recommend studying BEM Methodology
Happy coding❤️ Hope this was helpful
Marked as helpful1@michel-moreiraPosted almost 2 years ago@superpooperxxx thanks for your comments and tips, I will definitely implement them. I appreciate your recommendation and I'll spend a lot of time studying haha. Thanks to the compliment too!
It was really helpful for sure!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord