Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

NFT-preview-card-component-main

Faith 420

@fnwork

Desktop design screenshot for the NFT preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Any suggestions will be appreciated:)

Community feedback

@VCarames

Posted

Hey there! 👋 Here are some suggestions to help improve your code:

  • Do not forget ⚠️ to check your FEM report, to see what is incorrect and update your code with it right after you submit your challenge.
  • The "NFT image" alt tag description needs to be improved upon ⚠️. Assume that you are describing the image to a someone over the phone.

More Info:📚

https://www.w3.org/WAI/tutorials/images/

  • The “icons” in this component are purely decorative. ⚠️ Their alt tag should be left blank and have an aria-hidden=“true” to hide them from assistive technology.

More Info:📚

[MDN Aria-Hidden] (https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-hidden#description)

  • The profile image alt tag needs to be improved ⚠️. It should only state the following; “Headshot of -person’s full name-“

More Info:📚

Headshot Alt Text

  • The "Creation of Jules Wyvern" is not a heading ❌. It should instead be wrapped in a paragraph element.
  • Wrap the "NFT image", "Equilibrium #3429" and "Jules Wyvern" in an anchor tags ⚠️. The anchor tag will allow users to click on content and have them directed to another part of your site.

More Info:📚

MDN The Anchor element

If you have any questions or need further clarification, feel free to reach out to me.

Happy Coding! 🎆🎊🪅

0

@VCarames

Posted

  • Your CSS Reset is being underutilized. 😢 To fully maximize 💯 it, you will want to add more to it.

Here are some examples that you can freely use:

Josh Comeau Reset

Eric Meyer Reset

  • For improved accessibility 📈 for your content, it is best practice to use rem for your font-size and other property values. While em is best for media-queries. Using these units gives users the ability to scale elements up and down, relative to a set value.
0
Faith 420

@fnwork

Posted

@vcarames Thank you so much I will check the links out🙏

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord