Preview-Card-Component-Main

Community feedback

• Account deleted

  This comment was deleted almost 2 years ago

  0

  ---

  

  Muxammed•300

  @MuxammedziPosted almost 2 years ago

  @Khris26 İ don't use https://meyerweb.com/eric/tools/css/reset/ because I don't use all of them. I only use what I need. But do i need to use all of CSS reset?

  0

  

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  @Khris26

  He is using a resets but it is extremely minimal.

  * {
      padding: 0;
      margin: 0;
      box-sizing: border-box;
      text-decoration: none;
  }
  

  Why would the user need all of them?

  0
• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  wrap <div class="attribution"> in the footer tag and replace <h2> with <h1> to fix the accessibility issues.

  There is no need to give .container and .inner-info a height value.

  Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  0

  ---

  

  Muxammed•300

  @MuxammedziPosted almost 2 years ago

  @Hassiai Thanks for your tips

  0