Submitted over 2 years ago
NFT preview card component, vanilla HTML, CSS
@arevalosebastian
Design comparison
SolutionDesign
Solution retrospective
Always gratefull with feedbacks: D
Community feedback
- @denieldenPosted over 2 years ago
Hi Sebastian, I took some time to look at your solution and you did a great job!
Also I have some tips for improving your code:
- add
main
tag and wrap the card for Accessibility - add descriptive text in the
alt
attribute of the image - remove all unnecessary code, the less you write the better as well as being clearer: for example the
header
tag container of image - To make it look as close to the design as possible set
width: 22rem
tocomponent
class - instead of using
px
or%
try to use relative units of measurement likerem
-> read here
Overall you did well :)
Hope this help and happy coding!
Marked as helpful1 - add
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord