Design comparison
Solution retrospective
Any feedback is appreciated, please don't hesitate !
Community feedback
- @ratul0407Posted 12 months ago
@ThornenSan congrats on completing this challenge🎉🎉
You've done a really great job✨. The solution is really great but one thing that caught my eye is that you've used a
div
tag for almost everything. Whenever you needed a container you used adiv
. There is nothing wrong withdivs
they are ideal container. But you should work a little bit on landmarks as they provide a great value for accessibility. You could've used amain
as a background container. You could've used afooter
for the.attribute
div. This will help you to cope with accessibility along the way.These are little nick picks and instead of that the solution is great👍
Have a very nice day and keep up the good work🎉😄😄
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord