Design comparison
SolutionDesign
Community feedback
- @AGutierrezRPosted 11 months ago
Hello there 👋. Good job on completing the challenge!
I have some suggestions about your code that might interest you.
General Structure and HTML:
- Consider using
<span>
instead of paragraphs for elements that are not actual paragraphs. For example,<span>0.041 ETH</span>
and<span>3 days left</span>
Accessibility and Semantic HTML:
- The illustration image is decorative, so its alt text must be empty:
alt=""
. - Profile image could benefit from a more descriptive alt text, like
alt="Headshot of Jules Wyvern"
.
I hope you find this helpful 😁. Most importantly, your submitted solution is fantastic!
Happy coding!
Marked as helpful0@RanitManikPosted 11 months ago@AGutierrezR Thank you very much for showing me how to make my code more accessible. I have made the necessary changes and am looking forward to receiving suggestions for my future challenges.
1 - Consider using
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord