NFT Preview Card Component using HTML & CSS

Community feedback

• 

  gfunk77•1,200

  @gfunk77Posted 12 months ago

  Nice job on your solution. I can see that you were successful in creating the hover effect and eye. Nice! I have a few general comments that I hope are helpful.

  • please format your code. highlight everything and right click, there should be an option to format. This will make it a lot easier for others (and you!) to review your code.
  • on your parent container, in your case the body, add a min-height: 100vh; This will make the viewport a minimum of 100% and take away the scroll.
  • I can see that for your classes you are using the tag name with a dash like this <p class="p-1></p>" It will be much better to use actual names because you are going to have many, many p's and div's in your projects. No one will remember what class="div-43" will refer to. I'd look into a system like BEM if some structure is what you need.
  • You don't have to put the <svg> directly into your code. You can use <img src=" path/to/your/image/file" /> This is better especially because svgs can be thousands of lines of code.

  I hope all this is helpful.

  Marked as helpful

  2

  ---

  

  Mfrekemfon•120

  @MfrekeePosted 12 months ago

  @gfunk77 Thank you, I'd do all that and commit the new changes.

  0