Travolgi 🍕• 31,420
@denielden
Posted
Hi Katleho, I took some time to look at your solution and you did a great job!
Also I have some tips for improving your code:
- add
main
tag and wrap the card for Accessibility - remove all unnecessary code, the less you write the better as well as being clearer: for example the multiple
div
container of card and<br>
- to make it look as close to the design as possible add
width: 20rem and padding: 1rem
to.child-container2
class and removeheight
- remove all
margin
from.child-container2
class - try to use flexbox to the body for center the card. Read here -> best flex guide
- after, add
min-height: 100vh
to body because Flexbox aligns child items to the size of the parent container - remove all
position: absolute
from bottom element of card and use a div container withdisplay: flex
for align them - You can add the effect
:hover
creating adiv
that appears on hover. I used tailwind but you can still see and understand which css properties you can use to do the same. Look here -> my solution
Overall you did well 😉
Hope this help and happy coding!
0