Design comparison
SolutionDesign
Solution retrospective
Hi! , If you have any suggestion or feedback will be appreciated. π
Community feedback
- @fernandolapazPosted over 1 year ago
Hi ππ», some of this may interest you for future projects:
- When there is a hover state over an element it means that it is interactive, so it should be an interactive element around it (like a link or a button). So, the image should be wrapped with
<a>
or<button>
(depending on what happened when clicking on it), and also 'Equilibrium #3429' and 'Jules Wyvern' should be wrapped with the<a>
tag.
- In cases like this where the content is centered on the page it is better to use
min-height: 100vh
for the body as usingheight
causes the page to be cut off in viewports with small height (such as mobile landscape orientation).
- Consider using rem for
font-size
as well as it is better for scalable layouts.
I hope itβs useful : )
Regards,
Marked as helpful1 - When there is a hover state over an element it means that it is interactive, so it should be an interactive element around it (like a link or a button). So, the image should be wrapped with
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord