NFT preview card component using floats and position absolute/fixed

Community feedback

• 

  P

  Remus D. Buhaianu•3,125

  @MiculinoPosted almost 3 years ago

  Hey @AdrianX19

  Good job on completing the challenge. Your solution looks really nice!

  Just a few suggestions based on your code and final design:

  • Your card is a bit too big on larger screen sizes. On mobile screen size, it looks perfect, so try to emulate those kind of dimension ratios for the larger screen sizes as well

  • Don't use floats. They belong to the past. There are more modern, clean, and efficient solutions to building layouts using CSS. Look into Flexbox and CSS Grid. They are life changers for any frontend dev just starting out

  • You can align your card using various methods (absolute positioning is one of them) https://www.youtube.com/watch?v=njdJeu95p6s&ab_channel=Fireship

  Marked as helpful

  0

  ---

  

  Adrian H•420

  @AdrianX19Posted almost 3 years ago

  Hey @Remus432,

  thank you so much for your feedback! about the floats - you are right, it's past, I did the previous challenge with flexbox but just wanted to challenge myself to do something with floats - you know.. just for fun :) and thanks for the yt video - very useful! :)

  0