Design comparison
Solution retrospective
My question is about the view icon when hovering the NFT image.
NOTE: I didn't use any figma files, i've only use the given assets.
I didn't succeed to make it fully white as expected on the active state design, any feedback / best practices about the hover state is appreciated.
Community feedback
- @moi21devPosted over 1 year ago
Hi N40h,
congratulations on completing this challenge! : )
I had a took at your code, I am a newbe but I guess that the problem is in these lines:
.nft-container:hover .overlay { cursor: pointer; opacity: 0.5; }
Try to separate the background-color and the image, so you can set the hover aquamarine color to
opacity: 0.5
, and the image toopacity: 1
This way, the image will be white, on a semi-transparent background color.Marked as helpful1@N40hPosted over 1 year agoHi @moi21dev,
You absolutely right ! The issue was indeed in these lines, following your suggestion allow me to fix it. :D
Thanks a lot, really appreciated !
0@moi21devPosted over 1 year ago@N40h I'm glad you could fixed it! And thank you for marking my reply as helpful : )
0 - @0xabdulkhaliqPosted over 1 year ago
Hello there š. Congratulations on successfully completing the challenge! š
- I have other recommendations regarding your code that I believe will be of great interest to you.
DECORATIVE SVG'S āØļø:
- The
alt
attribute is used to provide alternative text for images in HTML documents. Thealt
attribute is used by screen readers to describe the image to visually impaired users, which is essential for web accessibility.
- Now, when it comes to decorative
SVGs
, they are used purely for aesthetic purposes and do not convey any important information or functionality to the user.
- Since these images do not convey any important information or functionality, there is no need for an
alt
attribute.
- So feel free to set the
alt
attribute as""
for decorativesvg's
, becausealt=""
will be skipped by screen readers they will consider the image as decoration
Example:
<img src="images/decorative.svg" alt="">
<img id="eth" src="./images/icon-ethereum.svg" alt="Ethereum Icon"> š <img id="eth" src="./images/icon-ethereum.svg" alt="">
.
I hope you find this helpful š Above all, the solution you submitted is great !
Happy coding!
Marked as helpful0@N40hPosted over 1 year agoHi @0xAbdulKhalid,
I didn't know that for decorative SVGs, really great tips, thank you.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord