NFT preview card component using Flex Box CSS

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted about 2 years ago

  Hey @Chermann-KING, some suggestions to improve you code:

  • The Background Image Property is only to be used on decorative images. NOT images that add value and serve a purpose. For this challenge you want to use the Image Element.

  • Once you fix the image issue, You'll want to include an Alt Tag with it. You want it to describe what the image is; they need to be readable. Assume you’re describing the image/icon to someone.

  • The Icons serve no other purpose than to be decorative; They add no value. Their Alt Tag should left blank and have an aria-hidden=“true” to hides it from assistive technology.

  • The "NFT image", "Equilibrium #3429" and "Jules Wyvern" in an Anchor Tags <a>. The anchor tag will allow users to click on content and have them directed to another part of your site.

  • Your CSS Reset is extremely bare and being underutilized. To fully maximize your CSS reset, you want to add more to it.

  Here are few CSS Resets that you can look at and use to create your own or just copy and paste one that is already prebuilt.

  https://www.joshwcomeau.com/css/custom-css-reset/

  https://meyerweb.com/eric/tools/css/reset/

  http://html5doctor.com/html-5-reset-stylesheet/

  Happy Coding!

  1
• 

  Chermann KING•430

  @Chermann-KINGPosted about 2 years ago

  **Hi @vcarames! Thanks for your feedback! ** I've taken your recommendations into account and updated my code. If you want to take a look again and tell me what you think ;)

  0