@ApplePieGiraffe
Posted
Greetings, Shha5! 👋
Good job on this challenge! 👏 Your solution looks great! 🙌
One thing I'd like to suggest is to make the alt text for the icon images in the card component an empty string so that they will be ignored by screen readers. That’s because those elements aren't necessary/important for the content of the page and as a result doesn’t need to be noticed by screen readers.
And be sure to use rem and em in as many places as possible (not px if you can avoid it) so that the text and overall design of your site will scale with the root/parent font size. 😉
It would also be nice to add a favicon to the site. There should be one in the starter files for this challenge that you can use.
Hope you find these tips helpful. 😊
Keep coding (and happy coding, too)! 😁
Marked as helpful
@Shha5
Posted
@ApplePieGiraffe Thank you for feedback! I'll use your tips in the next challenge I do <3 Happy coding :)
