Travolgi 🍕• 31,420
@denielden
Posted
Hello Zarko, You have done a good work! 😁
Some little tips to improve your code:
- also you can use
articletag instead of a simpledivto the container card for improve the Accessibility - remove all
marginfrom.containerclass - use flexbox to the body to center the card. Read here -> best flex guide
- after, add
min-height: 100vhto body because Flexbox aligns child items to the size of the parent container
Keep learning how to code with your amazing solutions to challenges.
Hope this help 😉 and Happy coding!
0
Zarko Petrov• 210
@zp021
Posted
@denielden Thank you for the response. That makes prefect sense, I used flexbox in the body to center the card in the last challenge, the product preview card, I don't know why I put margins this time. Thanks for the flex guide, that helps.
1
Travolgi 🍕• 31,420
@denielden
Posted
@zp021 you are welcome and keep it up :)
0
Travolgi 🍕• 31,420
@denielden
Posted
@zp021 you are welcome and keep it up :)
0
