Design comparison
SolutionDesign
Solution retrospective
Please review my code, and help me improve :)
I would like feedback on my code formatting too :)
Community feedback
- @RioCantrePosted over 2 years ago
Hello there! Great work with this one. Regarding the solution you submitted, I think you should know the following notes…
- The HTML structure is well organized with description on every section. Though you need to apply semantic tags to make it more readable, refer it with this one Semantics. For example, this line
<div class="nft-container">
which is the start container can be wrap withmain
tag and this one<div class="nft-details">
under the NFT details could be wrap withsection
tag. There are other possibilities to use more semantic tags - Great job with the hover state of the design specially the hero image. Include
cursor: pointer
to make it look clickable. - The CSS file is clean and organized. Well use of sizing elements.
- The project is responsive and utilized details accordingly
- You could add
margin: 0 0.5rem;
in the.nft-details
,.nft-price-info
and.avatar
rule sets to make it align with the hero image.
Above all, The project is awesome! Keep it up!
Marked as helpful1 - The HTML structure is well organized with description on every section. Though you need to apply semantic tags to make it more readable, refer it with this one Semantics. For example, this line
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord