NFT preview card component solution By Dev

Community feedback

• 

  PhoenixDev22•16,950

  @PhoenixDev22Posted over 2 years ago

  Hello Debadutta Panda,

  Congratulation on completing this challenge. Excellent work! I have few suggestions regarding your solution, if you don't mind:

  HTML

  • You can use <footer> landmark for the attribution.HTML5 landmark elements are used to improve navigation.

  • The most important part in this challenge interactive elements. Since there's a :hover state on the image and means it's interactive, So there should be an interactive element around it. When you create a component that could be interacted with a user , always remember to include interactive elements like(button, textarea,input, ..) for this imagine what would happen when you click on the image, there are two possible ways:
    1: If clicking the image would show a popup where the user can see the full NFT, here you use <button>. 2:If clicking the image would navigate the user to another page to see the NFT, here you can use <a>.

  For the same reason, use <a> to wrap Equilibrium #3429 and Jules Wyvern.

  • The link wrapping the equilibrium image should either have Sr-only text, an aria-label or alt text that says where that link takes you.

  • For any decorative images, each img tag should have empty alt="" and add aria-hidden="true" attributes to make all web assistive technologies such as screen reader ignore those images in (icon-view, icon-ethereum, icon-clock ).

  • look up a bit more about how and when to write alt text on images. Learn the differences with decorative/meaningless images vs important content

  • If you wish to draw a horizontal line, you should do so using appropriate CSS. You may remove the <hr>, you can use border-top: to the avatar's part.

  • To use more semantic tags, you may use <figure> and <figcaption> for the avatar's part.

  • Images must have alt attribute. Profile images like that avatar are valuable content. You can use the creator's name Jules Wyvern. Read more how to write an alt text

  • Never use <div> and <span>alone to wrap a meaningful content. Just keep in mind that you should usually use semantic HTML in place of the div tag unless none of them (the semantic tags) really match the content to group together. By adding semantic tags to your document, you provide additional information about the document, which aids in communication.

  • For middle part of the card class="flex gap-x-20", you can use an unordered list <ul>, in each <li> there should be <img> and <p> that way you can align them centrally.

  • There are so many ways to do the hover effect on the image, The one I would use is pseudo elements::before, ::after. You can use pseudo-elements to change the teal background color to hsla. Then the opacity can be changed from 0 to 1 on the pseudo element on the hover. Also using pseudo elements makes your HTML more cleaner as there's no need for extra clutter in the HTML. The icon view doesn’t really need to be in the HTML. You can use CSS for it.

  • Adding rel="noopener" or rel="noreferrer" totarget="_blank"links. When you link to a page on another site using target=”_blank”attribute , you can expose your site to performance and security issues.

  Overall, Great job on this one. Hopefully this feedback helps.

  Marked as helpful

  0
• 

  Lucas 👾•104,340

  @correlucasPosted over 2 years ago

  👾Hello Debadutta Panda, congratulations for your new solution!

  Your solution is great, the only thing I could change is the box-shadow that is too strong, this case you can give it less opacity and then fix the container alignment:

  Give the proper aligmnet using flexbox and min-heightin the body

  body {
      min-height: 100vh;
      display: flex;
      align-items: center;
      justify-content: center;
      flex-direction: column;
  }
  

  👋 I hope this helps you and happy coding!

  Marked as helpful

  0