Design comparison
Solution retrospective
In the style guide, it stated "The designs were created to the following widths:
- Mobile: 375px
- Desktop: 1440px".
I am not sure what the best practice is to make the page responsive to the above screen widths. I had an @media query setting the max-width to be 400px and reducing the root font size, and then the page looked alright on my phone.
Thanks in advance for any suggestions!
Community feedback
- @ehoda9Posted over 2 years ago
Mobile: 375px Desktop: 1440px".
- you can use a pixel-perfect helper tool or extension and use chrome developer to resize your screen to 1400x800
0@rendongzhaPosted over 2 years ago@ehoda9 Thanks for the advice. Will definitely try the tool!
0 - @SamadeenPosted over 2 years ago
Hey!! Cheers 🥂 on completing this challenge.. .
Here are my suggestions..
- You should use
<main class="container">
instead of<div class="container">
. - You can wrap your attribution section in a
footer tag
to avoid accessibility issues. - You should add a
alt
text to yourimg
tag to aid screen-readers
This should fix most of your accessibility issues
. Regardless you did amazing... hope you find this useful... Happy coding!!!
0@rendongzhaPosted over 2 years ago@Samadeen Thanks for the suggestions! I will try to use more HTML5 semantic tags in the future.
0 - You should use
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord