Design comparison
Solution retrospective
I'll appreciate any feedback. Thank you.
Community feedback
- @nenadmnePosted almost 2 years ago
Looks like a nice and simple solution.
Only thing i would add is that icon position (eye in the center of equilibrium photo).
<div class="icon-img"> <img src="images/icon-view.svg" alt="icon-view"> </div>
Try to either use
z-index
or pseudo::before
to fix its background color, as it should be white on hover.Happy coding =)
Marked as helpful0 - @csmurilloPosted almost 2 years ago
Hello Joshua, Great job in creating this NFT card component. I think their is not much area for improvement for this project but i do suggest the following:
1. I noticed that you wrap the whole card component inside an section tag, but a more appropriate tag would be the <article></article>. Article tag are used to wrap card components.Article Tag
2. I think you should add the
style cursor: pointer;
to the class .overlay of the image.Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord