NFT Preview Card Component SASS/SCSS

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 2 years ago

  Hello, Nick! 👋

  Nice work on this challenge! 🙌

  I would suggest perhaps not putting your media queries in a separate file in your Sass files. Splitting your styles down into separate files is a good idea, but it might be slightly annoying/tedious to switch back and forth between two files to tweak styles for the same element(s) and placing all (or most) of your styles for a particular element in the same place may give you a better idea of what's happening in your code (especially for a smaller project such as this, where it makes a lot of sense to group styles together in that way).

  Also, the reason specifying values such as `margin`, `padding`, `font-size`, and more in a responsive unit such as `em` or `rem` (not `px`, which is a fixed unit) is a good idea is to ensure that changing the font-size of the document causes the rest of the site to scale up/down (which is important for accessibility reasons). To learn more about `em` and `rem`, see this helpful article.

  Hope this helps. 😊

  Keep coding (and happy coding, too)! 😁

  Marked as helpful

  2

  ---

  

  Nick•30

  @NickTalvyPosted over 2 years ago

  @ApplePieGiraffe thank you for your feedback. What you said makes sense. The article was also helpful. Thanks again!

  1

  

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 2 years ago

  @NickTalvy

  Glad to help! 😊

  0