NFT preview card component

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  Hello there, Arturo! 👋

  I have some recommendations for the solution.

  • It's important to use semantic HTML instead of div and span elements only. Right now, search engine bots and screen readers would not be able to understand the page content because everything looks the same as far as the meaning. div and span have no meaning for them.
  • There's an active states on some elements. So, I recommend trying to create the active states styling after you refactor the HTML markup.
  • I would highly recommend not specifying the height of the container. If you have to, I recommend using min-height instead.
  • Set a max-width instead of width on the card element. This way, it allows the card to shrink if needed and prevent the card from becoming too large on wide screen.

  I hope this feedback is useful! 😁

  Marked as helpful

  1

  ---

  

  Arturo Muñoz•170

  @arturo0427Posted over 2 years ago

  @vanzasetia Thank you very much for the recommendation I will take it into account from now on :)

  0

  

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  @arturo0427 You're welcome! 👍

  0