NTF Preview FrontEnd Mentor Project

Community feedback

• 

  Felipe Salazar•140

  @andressalazar08Posted almost 2 years ago

  Hi Friend, I congratulate you on the project. I have done this same project and there are a few things I would like to help you improve.

  -The repository would be more eye-catching if you edit the Readme to better present the visitor. Also share the links in the Readme so everyone can check your solution.

  -The images must have an alt="some description" to improve the position in search engines and in case is not rendered by web browsers.

  -You can try replacing the <h6>0.041ETH</h6> tag with a <p class="price-days-p"> and style it
  .price-days-p{ font-size: 1rem; } In this way you can better control the font-size

  -Try to use relative length units like rem instead of px. In this way you can alter the size of the fonts if you change it in the root in a global way. For example font-size: 1rem means 16px. I share with you this article to see why. https://wisdmlabs.com/blog/css-fixed-relative-units-measurement-font-size/

  -To be close to the design the box-shadow on the card is not necessary.

  -You need to add the hover effect on the image. You can do this by using a div with background-image: none; then in the hover effect you can add the opacity required. something like this:

  .hidden-image:hover{
      background-image: url("images/icon-view.svg");
      background-color: var(--Cyan);
      opacity: 0.5;
  }
  

  That would be all, have a nice day. Happy coding!!

  Marked as helpful

  0
• 

  Bharanidharan M•50

  @bharanidev-001Posted almost 2 years ago

  thank you so much for your feedback, struggling with change the background while hover thanks for your solution

  0