NFT preview card component

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted about 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  DECORATIVE SVG'S ♨️:

  • The alt attribute is used to provide alternative text for images in HTML documents. The alt attribute is used by screen readers to describe the image to visually impaired users, which is essential for web accessibility.

  ---

  • Now, when it comes to decorative SVGs, they are used purely for aesthetic purposes and do not convey any important information or functionality to the user.

  ---

  • Since these images do not convey any important information or functionality, there is no need for an alt attribute.

  ---

  • So feel free to set the alt attribute as "" for decorative svg's, because alt="" will be skipped by screen readers they will consider the image as decoration

  ---

  Example:

  <img src="images/decorative.svg" alt="">
  
  

  <img src="images/icon-ethereum.svg" alt="ethereum">
    👇
  <img src="images/icon-ethereum.svg" alt="">
  
  

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1
• 

  solitary_coder•1,000

  @kabir-afkPosted about 1 year ago

  Hey!!!! , good job on completing the challenge , I saw your query and on reviewing your code , I must say that your approach is almost ideal , it is just instead of using an extra element such as .overlay-img you could have used a pseudo selector like .card-hero-img::before, with rest of the code being same. I approached it the same way you did , except with the corrections made , I couldn't find any other method either . . . good work btw 🥂🥂

  Marked as helpful

  0

  ---

  

  Joeybur•310

  @JoeyburPosted about 1 year ago

  @kabir-afk

  Hey, thanks for the response!

  I did consider using pseudo elements, but my brain kinda drew blank with the approach to take afterwards. It's good to know i can approach it the same way.

  0

  

  solitary_coder•1,000

  @kabir-afkPosted about 1 year ago

  @Joeybur .card-hero-img::before:hover{ //Something like this might've worked }

  0