Design comparison
Solution retrospective
Here is my solution to the NFT preview card component solution āØ I still find it challenging to understand all the best practices for CSS/HTML, so ...any tips for it?
š Happy to hear any feedback and advice. Thanks!
Community feedback
- @AbdalrzakalsoukiPosted almost 2 years ago
Hello, that is look great
here some suggestions:
- Accessibility:
- Heading should only increase by one, means you go from h3 to h4, not h3 to h5, this is important for SEO
- HTML validations:
- use heading with article
- General:
- importing the fonts in CSS is not really good for performance, unless you need a lot of customization, better to include it in HTML head
- this is optional but you can use some variables with CSS, it make modifying much easier
- do not put the custom CSS before Google fonts, this will reduce the performance
- you can minimize the code for better performance
- use a meta description
hope this is helpful, all luck
Marked as helpful2 - @SameerJS6Posted almost 2 years ago
"Nice one, buddy, but you forgot to add hover effects on the link tags (Creators Name, Price) and on the main image. You also forgot to add a cursor: pointer to some links. Always make sure to decrease the heading tag only by one. For example, if you have used h1, you should not use h4 directly on the page; it should only decrease one by one."
Thank You,
Marked as helpful1@PaulaR-05Posted almost 2 years ago@SameerJS6 Thank you :) I'm going to correct everything you said, thanks a lot!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord