NFT Preview Card Component

Community feedback

• 

  T

  Grace•31,210

  @grace-snowPosted almost 2 years ago

  This looks pretty good. Main issues that need fixing are

  • the anchor tag around the card images needs accessibly labelling. Where would clicking that link go??
  • alt on the icons should be intentionally left blank as they are decorative
  • the component is hitting my screen edges on all sides. Make sure you add a little margin to the component or padding on its wrapper
  • give the component a max width instead of width so it can shrink if it needs to. Even better if this is in rem
  • opacity only needs to go between 0 and 1 (not 100)

  0

  ---

  

  Sagun Shrestha•160

  @SaguneoPosted almost 2 years ago

  @grace-snow All notes taken! Thank you so much for your feedback and guidance.

  0