NFT preview card component (my take) HTML, CSS

Community feedback

• 

  Panji•2,090

  @pperdanaPosted over 1 year ago

  Hi, Well done on completing the challenge! 👍

  • I have other recommendation for your code to center an element both horizontally and vertically.

  Using relative position

  Since you use flexbox to center element both horizontally and vertically, you can also use relative position to do it.

  Set the position property of the child element to "absolute" and use the "top", "bottom", "left", and "right" properties to center the element both horizontally and vertically. For example:

  .parent {
    position: relative;
  }
  
  .child {
    position: absolute;
    top: 50%;
    left: 50%;
    transform: translate(-50%, -50%);
    /* other styles for the child element */
  }
  

  I hope this information was beneficial for you! 😊

  Happy coding🤖

  Marked as helpful

  1
• 

  Abdul Khaliq 🚀•72,580

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution may cause accessibility errors due to lack of semantic markup, which causes lacking of landmark for a webpage and allows accessibility issues to screen readers, due to accessibility errors our website may not reach its intended audience, face legal consequences, and have poor search engine rankings, highlighting the importance of ensuring accessibility and avoiding errors.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers

  ---

  • For example:
    • The <main> element should include all content directly related to the page's main idea, so there should only be one per page
    • The <footer> typically contains information about the author of the section, copyright data or links to related documents.

  ---

  • So resolve the issue by replacing the <div class="card"> element with the proper semantic element <main> in your index.html file to improve accessibility and organization of your page

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1

  ---

  

  Bosca Darius•120

  @dariuss1123Posted over 1 year ago

  @0xAbdulKhalid thank you very much. that's some solid advice and surely something i'll consider doing in the future projects. have a nice day

  0