Submitted over 2 years ago
NFT preview card component layout [With SASS/SCSS]
@Lino-OTM
Design comparison
SolutionDesign
Solution retrospective
I would be very grateful if you could check my code and send me some feedback :) I know it is a very simple challenge but any opinion is welcome.
Community feedback
- @RioCantrePosted over 2 years ago
Hello there! Great work with this one. Regarding the solution you submitted, I think you should know the following notes…
- This line
<div class="attribution">
can be wrap withfooter
tag or place it inside thearticle
tag - The Sass file can be break into smaller parts, for instance, a separate file for variables.
- Include description with the
alt
in image tags but that is optional
Other than that...
- The project is responsive and utilized the details based on the original design
- Well done in using Sass for styling, the composition and properties are done accordingly
- Proper usage of semantic tags
- The HTML structure is well organized and readable
- The hover state of the design is done properly, specially the hero image
Above all, The project is awesome! Keep it up!
Marked as helpful1@Lino-OTMPosted over 2 years ago@RioCantre I really appreciate these comments more than you can believe, I will implement them in my next projects to improve more and more and have very good practices!
I really appreciate your time! Thank you very much!
0 - This line
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord