Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

NFT preview card component

@Singatha

Desktop design screenshot for the NFT preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


How do I make the hr thinner?

Community feedback

Travolgi 🍕 31,420

@denielden

Posted

Hi Xhanti, good job! I took some time to look at your code and have some ideas for improving it:

  • add main tag and wrap the card for improve the Accessibility
  • remove all margin from container class because with flex they are superfluous
  • use flexbox to the body for center the card
  • after, add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container
  • add a little transition on the element with hover effect

Overall you did well 😉

Hope this help and happy coding!

1

@shameerkamaludeen

Posted

Hi @Singatha good job,

I would recommend looking at the stack overflow question for that, actually, the question is regarding the color of it but you can use border property to help your situation.

If you would like you can have a look at my solution to know how I did it.

Enjoy coding...

1
SaakarX 320

@saakarx

Posted

Hello Xhanti Singatha, good job on the solution and great feedback above.

  • Read about semantic. Semantic elements lead to more consistent code, they are easier to read and improve accessibility.
  • And for making the <hr> thinner, use border-width: 1px 0 0; on the hr tag to make it thinner.

Good luck with that, have fun coding! 💪

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord