designed an nft card using html and css

Community feedback

• 

  Felipe Salazar•140

  @andressalazar08Posted almost 2 years ago

  @maxibrain4

  Hello Friend, first of all I congratulate you on the delivery. I have tackled this challenge and I could recommend a couple of things.

  1.Take advantage of the README-template that is shared to give a description to the delivery. It is an aspect that will greatly help whoever visits your github to understand what the project is about.

  2.I see that you are not using the recommended family-font. Check the style guide to find out which one to use on the projects. In this case: - Family: Outfit Weights: 300, 400, 600

  3.It is convenient to define colors in root to access them as variables. I see that you define the colors in each case and for each element. Using the variables will help you to be more precise in the tone of the suggested design. On the other hand you can make a global change that applies to various elements of your DOM by making an adjustment in root. I share an article on the subject. Link to variables in root

  4.You use font-size in pixels. Use relative measures like rem to define these units of length. This helps accessibility and responsive design aspects. By default 1rem ==16px. I share an article about it. article about rem.

  I think that for now is what I can contribute. Happy coding!! Felipe.

  0