Skip to content
Submitted over 2 years ago

NFT Preview Card Component

Qmir•100
@Qmirdev
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...NFT preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

That was Awesome!

Community feedback

  • Prince Roy•1,210
    @iprinceroyyPosted over 2 years ago

    Great @saffari-dev, I would suggest some points here:-

    1. If you are using the heading tag, then you should go from h1 to h6 successively. You can't skip one & jump to another. So here you should use h1 instead of h2.
    2. There should be one main landmark where goes the content like this ➡️ <body><main>your content</main></body> to avoid accessibility issues.
    3. Don't use div for separating text like you did for "credit" & "name" class rather merge these two in one paragraph tag & use the span tag for "name" inside the para tag.
    4. "alt" attribute is missing in the img tag, so fix it.

    Hope this adds to your learning, Happy coding :)

    Marked as helpful
    0
    Qmir•100
    @QmirdevPosted over 2 years ago

    @iprinceroyy , Thank you for your advices ❤️. I will fix them.

    0
  • Denis•1,060
    @Mod8124Posted over 2 years ago

    Good Job!

    that's pretty awesome 😍

    1
    Qmir•100
    @QmirdevPosted over 2 years ago

    @Mod8124 Thanks, I appreciate you 😍

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord