NFT preview card component hub + Flexbox

Community feedback

• 

  Lee•230

  @LeeConnelly12Posted over 2 years ago

  Good use of BEM to structure your classes.

  While moving in from the right, your blue overlay makes the corners look sharp Example

  To solve this you could set border-radius: 10px on the <picture element.

  This along with having overflow: hidden already set on your <picture> ensures that any content inside of the <picture> tag will not overflow the border radius.

  Marked as helpful

  0

  ---

  

  Eduardo•910

  @KTrick01Posted over 2 years ago

  @LeeConnelly12 Hi, i did it the way you said and now it looks cleaner, thanks for the advice!

  0
• 

  arey•350

  @arey-devPosted over 2 years ago

  Good day! You work is great!

  Here's my opinion. When using CSS custom variables, It's better to have a flexible name or should I say a 'general' name, i.e., --clr-primary, --clr-secondary, and --bg-clr. In this way, if you would ever change your code in the future, it would only be the value of the property, not the entire declaration. Happy coding!

  Marked as helpful

  0

  ---

  

  Eduardo•910

  @KTrick01Posted over 2 years ago

  @arey-dev I see, that makes sense! I will do it that way from now on, thanks!

  0
• 

  Ahmed_J_FrDev•30

  @ahmedJabbanPosted over 2 years ago

  Hi @KTrick01......

  I am like you as well, I don't have a lot of experience but I will say to you that you did good, I saw your code, for me, I didn't see any error..... There are some people (From the beginners) who can't do this project as you did or maybe they tried a lot but they couldn't do it in the end, be proud of yourself!.

  keep going, you have good skills!.....

  1

  ---

  

  Eduardo•910

  @KTrick01Posted over 2 years ago

  @ahmedJabban Hi! Thank you for your words!

  0