Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Request path contains unescaped characters
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

NFT preview card component hub + Flexbox

Eduardo 910

@KTrick01

Desktop design screenshot for the NFT preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hi! This is my first challenge in this community, im pretty new with css and html so i would like you guys to give me your feedback, even if it seems basic for you, im sure it will help me!

Community feedback

Lee 230

@LeeConnelly12

Posted

Good use of BEM to structure your classes.

While moving in from the right, your blue overlay makes the corners look sharp Example

To solve this you could set border-radius: 10px on the <picture element.

This along with having overflow: hidden already set on your <picture> ensures that any content inside of the <picture> tag will not overflow the border radius.

Marked as helpful

0

Eduardo 910

@KTrick01

Posted

@LeeConnelly12 Hi, i did it the way you said and now it looks cleaner, thanks for the advice!

0
arey 350

@arey-dev

Posted

Good day! You work is great!

Here's my opinion. When using CSS custom variables, It's better to have a flexible name or should I say a 'general' name, i.e., --clr-primary, --clr-secondary, and --bg-clr. In this way, if you would ever change your code in the future, it would only be the value of the property, not the entire declaration. Happy coding!

Marked as helpful

0

Eduardo 910

@KTrick01

Posted

@arey-dev I see, that makes sense! I will do it that way from now on, thanks!

0

@ahmedJabban

Posted

Hi @KTrick01......

I am like you as well, I don't have a lot of experience but I will say to you that you did good, I saw your code, for me, I didn't see any error..... There are some people (From the beginners) who can't do this project as you did or maybe they tried a lot but they couldn't do it in the end, be proud of yourself!.

keep going, you have good skills!.....

1

Eduardo 910

@KTrick01

Posted

@ahmedJabban Hi! Thank you for your words!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord