Design comparison
SolutionDesign
Community feedback
- @antoebtfrPosted over 2 years ago
Hi
I'm going to be picky just because depending on the customer some details will pass or not even if it's an excellent work
Bad points :
- The modal is not centered vertically
- We can see the .for-hover background on corners even if it's not in the hover state
- Not asked but could be nice to set a cursor: pointer on the picture
Good points :
- Responsive work well
- Accessibility with alt attributes
- The picture is never stretched
Feel for to ask for any advice or if you don't agree with something I said
Marked as helpful0@kristinalesnjakovicPosted over 2 years agoHi @antoebtfr, thank you for your feedback, I appreciate it!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord