NFT Preview Card Component - HTML/CSS

Community feedback

• 

  PhoenixDev22•16,950

  @PhoenixDev22Posted about 2 years ago

  Hello Jo Blaszak,

  Congratulation on completing another frontend mentor challenge.Excellent work! I have some suggestions regarding your solution:

  • The most important part in this challenge is the interactive element. Since there's a :hover state on the image and means it's interactive, So there should be an interactive element around it. When you create a component that could be interacted with a user , always remember to include interactive elements like(button, textarea,input, ...) For this imagine what would happen when you click on the image, there are two possible ways:

  1: If clicking the image would show a popup where the user can see the full NFT, here you use <button>.

  2: If clicking the image would navigate the user to another page to see the NFT, here use <a>.

  • You should have used <a> to wrap Equilibrium #3429 and Jules Wyvern too.

  • The link wrapping the equilibrium image (image-equilibrium) should either have Sr-only text, an aria-label that indicates where the link navigate the user(not describes the image).

  • For any decorative images, each img tag should have empty alt="" and add aria-hidden="true" attributes to make all web assistive technologies such as screen reader ignore those images in (icon-view, icon-ethereum, icon-clock).

  • look up a bit more about how and when to write alt text on images. Learn the differences with decorative/meaningless images vs important content

  • Never use <div> alone to wrap a meaningful content. Just keep in mind that you should usually use semantic HTML in place of the div tag unless none of them (the semantic tags) really match the content to group together. By adding semantic tags to your document, you provide additional information about the document, which aids in communication.

  • For the reason sated before, you can use unordered list <ul> to wrap the middle part of the component. In each <li> should be <img> and <p>.

  • There are so many ways to add the hover effect on the image , The one I would use, using pseudo-elements to change the teal bg color to a hsla. Then opacity can be changed from 0 to 1 on the pseudo element on hover. There is no need for a extra clutter in the HTML.

  • Adding rel="noopener" or rel="noreferrer" totarget="_blank"links. When you link to a page on another site using target=”_blank” attribute , you can expose your site to performance and security issues.

  Hopefully this feedback helps.

  Marked as helpful

  1

  ---

  

  Jo Blaszak•110

  @jblaszakPosted about 2 years ago

  @PhoenixDev22 Thanks! Really appreciate the thoroughness of your response with regards to best practices!

  I had mostly focused on just getting everything right positioning-wise for these challenges so far, but I realize now I'll have to double down on my efforts to bring things to the next level!

  0

  

  PhoenixDev22•16,950

  @PhoenixDev22Posted about 2 years ago

  @jblaszak Glad to hear that it was helpful. Happy coding!

  0