Design comparison
Solution retrospective
feedback are appreciated
Community feedback
- @AdrianoEscarabotePosted almost 2 years ago
Hello Deepak, how are you? Welcome to the community of front-end mentors! I truly loved your project's outcome, however I have some advice that I hope you'll find useful:
A good practice to center content is using
grid
orflex-box
, avoid using margin or padding to make placements, use only in the latter case! we can do it like this:Flex-box:
body { display: flex; align-items: center; justify-content: center; flex-direction: column; min height: 100vh; }
GRID
body { display: grid; min height: 100vh; place-content: center; }
To improve the structure of the html document, prefer to wrap all the content with the
main
tag, since this challenge is just a component, it needs amain
tag to know what the main content of the page is!The remainder is excellent.
I hope it's useful. 👍
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord