NFT Preview Card Component - HTML and CSS

Community feedback

• 

  Fabianthorsen•170

  @FabianthorsenPosted over 1 year ago

  Hey, good work on this one. Here are some of my pointers as to what I think you could have done differently:

  HTML:

  • <div class="main"> is not semantically the same as <main></main>. All HTML sites should have a main tag, and thus it should be quite simple to change. And thus rather have the main wrapping the div serving as a container.
  • Im unsure in the use of a section tag to enclose images that are inside of other objects. I think the a section or an article tag should be what wraps the other objects, meaning that it could make sense to use a section tag to wrap everything related to the text body, but not a div wrapping the section, if that made any sense.

  CSS:

  • Nice job using variables, but I would not use variables for anything that is just used once or twice.
  • When values are 0, such as the 0em you can omit the suffix, so 0em, 0px, 0rem can simply be written as 0.

  Im not a pro, and do not take everything I say face value, but hopefully some of my comments are helpful! :D

  0

  ---

  

  3AGLE-git•80

  @3AGLE-gitPosted over 1 year ago

  Hey there,

  Thanks for the feedback.

  0