Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

NFT Preview Card Component - HTML and CSS

3AGLE-git 80

@3AGLE-git

Desktop design screenshot for the NFT preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I will appreciate feedback on my codes and what i could have done better

Community feedback

@Fabianthorsen

Posted

Hey, good work on this one. Here are some of my pointers as to what I think you could have done differently:

HTML:

  • <div class="main"> is not semantically the same as <main></main>. All HTML sites should have a main tag, and thus it should be quite simple to change. And thus rather have the main wrapping the div serving as a container.
  • Im unsure in the use of a section tag to enclose images that are inside of other objects. I think the a section or an article tag should be what wraps the other objects, meaning that it could make sense to use a section tag to wrap everything related to the text body, but not a div wrapping the section, if that made any sense.

CSS:

  • Nice job using variables, but I would not use variables for anything that is just used once or twice.
  • When values are 0, such as the 0em you can omit the suffix, so 0em, 0px, 0rem can simply be written as 0.

Im not a pro, and do not take everything I say face value, but hopefully some of my comments are helpful! :D

0

3AGLE-git 80

@3AGLE-git

Posted

Hey there,

Thanks for the feedback.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord