Design comparison
SolutionDesign
Solution retrospective
Go on then, and give your feedback on this. Took me around 1.5 hours to build this with animations. So, Please tell me how is it ?!....
Community feedback
- @romila2003Posted about 2 years ago
Hi Sameer,
Congratulations 🎉 for completing this challenge, it was a great attempt. The card looks great and is responsive. I like the hover effect too.
- Regarding the accessibility issues, it is best practice to wrap the main content within the
main
tag which would ensure that your content is wrapped within the correct landmarks e.g.<main class="container"></main>
- You should also wrap the footer within the
footer
tag e.g.<footer class="attribution"></footer>
Overall, great attempt and wish you the best for your future projects so keep coding 👍.
0 - Regarding the accessibility issues, it is best practice to wrap the main content within the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord