NFT preview card component (💬 HTML & CSS)

Community feedback

• 

  PhoenixDev22•16,950

  @PhoenixDev22Posted over 2 years ago

  Hello

  Congratulation on completing this challenge. Excellent work! I have few suggestions regarding your solution, if you don't mind:

  HTML

  • The link wrapping the equilibrium image should either have Sr-only text, an aria-label or alt text that says where that link takes you.

  • For any decorative images, each img tag should have empty alt="" and add aria-hidden="true" attributes to make all web assistive technologies such as screen reader ignore those images in (icon-ethereum, icon-clock ).

  • Profile images like that avatar are valuable content. The alternate text of the avatar’s image should not be Avatar, it’s meaningless. You can use the creator's name Jules Wyvern. Read more how to write an alt text

  • The alternate text should not be hyphenated, it should be human readable.

  • look up a bit more about how and when to write alt text on images. Learn the differences with decorative/meaningless images vs important content

  • If you wish to draw a horizontal line, you should do so using appropriate CSS. You may remove the <hr>, you can use border-top: to the avatar's part.

  • There are so many ways to do the hover effect on the image, The one I would use is pseudo elements::before, ::after. You can use pseudo-elements to change the teal background color to hsla. Then the opacity can be changed from 0 to 1 on the pseudo element on the hover. Also using pseudo elements makes your HTML more cleaner as there's no need for extra clutter in the HTML.

  Great job on this one. Hopefully this feedback helps.

  Marked as helpful

  0

  ---

  

  Alexandre JOLIET•170

  @alexandre-jolietPosted over 2 years ago

  Hello @PhoenixDev22!

  Thank you very much for your feedback! I have fixed my code accordingly 🙂.

  Very interesting readings you gave me! Initially, I was thinking naively that every picture needed an alt text but I had no clue about their actual, and I suppose true purpose, for Accessibility.

  And nice tip for the line! I didn't think to create it with the border of an adjecent element.

  Thanks 🙏!

  1

  

  PhoenixDev22•16,950

  @PhoenixDev22Posted over 2 years ago

  @JojoRider

  Glad to help. Happy coding!

  0