Travolgi 🍕• 31,420
@denielden
Posted
Hello Jordan, You have done a good work! 😁
Some little tips to improve your code:
- also you can use
article
tag instead of a simplediv
to the container card for improve the Accessibility - You can fixthe effect
:hover
creating adiv
that appears on hover. I used tailwind but you can still see and understand which css properties you can use to do the same. Look here -> my solution - Using
<hr>
for the line is not the best way because this tag have a semantic meaning... in this case use div withborder-bottom
because this line is decorative - remove all
margin
fromcard
class because with flex they are superfluous - use
min-height: 100vh
to main tag instead ofheight
, otherwise the content is cut off when the browser height is less than the content - add
transition
on the element with hover effect - instead of using
px or %
use relative units of measurement likerem
-> read here
Keep learning how to code with your amazing solutions to challenges.
Hope this help 😉 and Happy coding!
0