Design comparison
Solution retrospective
I wanted to try out Frontend Mentor for a long time now, finally had the chance to attempt a challenge. I used vanilla CSS and HTML, would love some feedback if any I tried to use CSS custom properties for the first time.
Looking forward to doing more challenges!
Community feedback
- Account deleted
Hello there! 👋
Congratulations on finishing your challenge! 🎉
I have some feedback on this solution:
- Always Use Semantic HTML instead of
div
like<main>
<header>
, etc for more info
if my solution has helped you do not forget to mark this as helpful!
Marked as helpful1@dayumsamPosted over 2 years ago@Old1337 Okay, I will keep this in mind the next time, In this particular project where will you suggest I use the <main> tag>.
Thank you so much for your feedback.
1 - Always Use Semantic HTML instead of
- @RioCantrePosted over 2 years ago
Hello there! Great work with this one. Regarding the solution you submitted, I think you should also take notes of the following…
- Import the
attribution
style and font style in CSS file and remove thestyle
tag. Advisable not to use twostyle
tags within thehead
- Wrap the whole content with specific tag like
main
. For HTML structures, refer it with this one Semantics - Include description with the
alt
in image tags. Like this line<img src="./images/icon-view.svg" alt="">
- Add the inline style in the CSS file as well.
Above all, The design looks good. Keep it up! Hope this is helpful!
0 - Import the
- @EmmanuelHexerPosted over 2 years ago
Great work overall man. Keep it up
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord