Travolgi 🍕• 31,420
@denielden
Posted
Hello Jonathon, You have done a good work! 😁
The best way to learn and remember is to practice a lot… nothing more.
Some little tips to improve your code:
- add
main
tag and wrap the card for improve the Accessibility - also you can use
article
tag instead of a simplediv
to the container card for improve the Accessibility - remove all
margin
fromcard
class - use flexbox to the body to center the card. Read here -> best flex guide
- after, add
min-height: 100vh
to body because Flexbox aligns child items to the size of the parent container - add
transition
on the element with hover effect - Using
<hr>
for the line is not the best way because this tag have a semantic meaning... in this case use div withborder-bottom
because this line is decorative
Keep learning how to code with your amazing solutions to challenges.
Hope this help 😉 and Happy coding!
0