NFT Preview Card Component

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  COMPONENT MEASUREMENTS 📐:

  • Use min-height: 100vh for main instead of height: 95vh. Setting the height: 95vh may result in the component being cut off on smaller screens.

  ---

  • For example; if we set height: 95vh then the main will have 95vh height no matter what. Even if the content spans more than 95vh of viewport.

  ---

  • But if we set min-height: 100vh then the main will start at 100vh, if the content pushes the main beyond 100vh it will continue growing. However if you have content that takes less than 100vh it will still take 100vh in space.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1

  ---

  

  Carolina Kazmer•40

  @CarolinaKzPosted over 1 year ago

  Hi Abdul!

  Thank you very much for your recommendation, as always it's very helpful 😊

  I'll correct it!

  0