Design comparison
Community feedback
- @correlucasPosted about 2 years ago
👾Hello Bruno, Congratulations on completing this challenge!
Great code and great solution! I’ve few suggestions for you that you can consider adding to your code:
1.Don't forget to use the
alt
text to allow screen readers to recognize that img. Adding alternative text to photos is first and foremost a principle of web accessibility. Visually impaired users using screen readers will be read an alt attribute to better understand an on-page image.2.Here's how you can add the hover effect:
Container needed to position the overlay. Adjust the width as needed
.container { position: relative; width: 100%; max-width: 340px; }
Make the image to responsive
.image { width: 100%; height: auto; }
The overlay effect (full height and width) - lays on top of the container and over the image
.overlay { position: absolute; top: 0; bottom: 0; left: 0; right: 0; height: 100%; width: 100%; opacity: 0; transition: .3s ease; background-color: red; }
When you mouse over the container, fade in the overlay icon
.container:hover .overlay { opacity: 1; }
The icon inside the overlay is positioned in the middle vertically and horizontally .icon { color: white; font-size: 100px; position: absolute; top: 50%; left: 50%; transform: translate(-50%, -50%); -ms-transform: translate(-50%, -50%); text-align: center; }
When you move the mouse over the icon, change color
.icon-eye:hover { color: hsl(178, 100%, 50%, 0.5);; }
👨💻Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/nft-preview-card-vanilla-css-custom-design-and-hover-effects-b8D1k9PDmX
✌️ I hope this helps you and happy coding!
Marked as helpful1@bvictor-aPosted about 2 years ago@correlucas Thanks for the tips, they will definitely help me a lot.
0 - @VCaramesPosted about 2 years ago
Hey there! Here are some suggestions to help improve your code:
- The overlay hover effect was not applied. Here is a link that will show you how to apply it.
https://www.w3schools.com/howto/howto_css_image_overlay.asp
-
The NFT Alt Tag description needs to be improved upon. You want to describe what the image is; they need to be readable. Assume you’re describing the image/icon to someone.
-
Along with the blank alt tag, you also want to include the aria-hidden=“true” to your icons to fully remove it from assistive technology.
-
The profile image Alt Tag needs to be improved. It should state the following; “Headshot of -person’s full name-“
-
Wrap the "NFT image", "Equilibrium #3429" and "Jules Wyvern" in an Anchor Tags <a>. The anchor tag will allow users to click on content and have them directed to another part of your site.
-
A media query is not needed for this challenge. As long as your component is built using responsive properties, it will be responsive.
If you have any questions or need further clarification, let me know.
Happy Coding! 👻🎃
Marked as helpful1@bvictor-aPosted about 2 years ago@vcarames Thank you very much, it helped me a lot.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord