NFT preview card component

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted over 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • A Header Element is not needed for this challenge.

  • The NFT Alt Tag description needs to be improved upon. You want to describe what the image is; they need to be readable. Assume you’re describing the image/icon to someone.

  • Along with the blank alt tag, you also want to include the aria-hidden=“true” to your icons to fully remove it from assistive technology.

  • Wrap the "NFT image", "Equilibrium #3429" and "Jules Wyvern" in an Anchor Tags <a>. The anchor tag will allow users to click on content and have them directed to another part of your site.

  • A media query is not needed for this challenge. Using responsive properties is enough.

  If you have any questions or need further clarification, let me know.

  Happy Coding! 👻🎃

  Marked as helpful

  0
• 

  Lucas 👾•104,240

  @correlucasPosted over 2 years ago

  👾Hello @Lucascollins, Congratulations on completing this challenge!

  Great code and great solution! I’ve few suggestions for you that you can consider adding to your code:

  1.Add transitions to make the interaction smoother while the element gets hovered, you can use a value like transition: all ease-in 0.5s.

  2.Use units as rem or em instead of px to improve your performance by resizing fonts between different screens and devices.

  To save your time you can code your whole page using px and then in the end use a VsCode plugin called px to rem here's the link → https://marketplace.visualstudio.com/items?itemName=sainoba.px-to-rem to do the automatic conversion or use this website https://pixelsconverter.com/px-to-rem

  3.The box-shadow is a bit too strong, this is due the opacity and blur. The secret to create a perfect and smooth shadow is to have low values for opacity and increase blur try this value instead: box-shadow: 12px 7px 20px 6px rgb(57 75 84 / 8%);

  If you’re not familiar to box-shadow you can use this site to create the shadow design and then just drop the code into the CSS: https://html-css-js.com/css/generator/box-shadow/

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  0