NFT Preview Card

Community feedback

• 

  Favour•2,160

  @Nadine-GreenPosted almost 2 years ago

  HEY IBNUKHATHIR!

  Sorry about the situation with your laptop, hope you are able to fix it soon :)

  I have a few suggestions on how your code could be improved:

  • I viewed your code and i would like to reccoment putting all the images inside one folder, this will make thing more organised.

  • For the profile picture, there is no need to use the code aria-hidden="true" as in real life, the image would not be decorative and the screen reader will need to read your alt to describe the image to a disabled person.

  • Instead of using padding: 1.5rem 1.5rem 1.5rem 1.5rem; for the .container it would be more efficient to use the code padding:1.5rem, this will be putting padding on all four sides.

  • You will also need to increase your font sizes.

  • About your accesibiluty problem, you will need to use a semantic element like footer instead of a div for the <div class="attribution">, this will remove the error.

  HOPE I COULD BE OF HELP :)

  HAPPY CODING!

  Marked as helpful

  0
• 

  yishak abrham•2,150

  @yishak621Posted almost 2 years ago

  Good job keep coding ...there is also a mobile apps which will help u to kearn html css and JavaScript until ur pc repaired

  Marked as helpful

  0