Responsive page using HTML5, SASS and BEM.
Design comparison
Solution retrospective
I enjoyed completing this challenge.
I appreciate any feedback 'cause I know that there is always room for improvement.
Thank you! Elio Flores
Community feedback
- @VCaramesPosted about 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- The NFT
alt tag
description needs to be improved upon. This is what your users are purchasing. You want to describe what the image is; Assume you’re describing the image to someone over the phone.
More Info:📚
https://www.w3.org/WAI/tutorials/images/
- Wrap the "NFT image" and "Equilibrium #3429" in an
anchor tags
. The anchor tag will allow users to click on content and have them directed to another part of your site.
More Info:📚
- Your CSS Reset is extremely bare and being underutilized. To fully maximize your CSS reset, you want to add more to it.
Here are few CSS Resets that you can look at and use to create your own or just copy and paste one that is already prebuilt.
https://www.joshwcomeau.com/css/custom-css-reset/
https://meyerweb.com/eric/tools/css/reset/
http://html5doctor.com/html-5-reset-stylesheet/
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding!🎄🎁
1@eliofloPosted about 2 years ago@vcarames Thanks for your feedback, helps me a lot!
I updated my repo adding an anchor tag, alt property, and normalize file (scss file). From now on I will use normalize in the frontendmentor challenges.
Merry Christmas!🎄
Elio Flores
0 - The NFT
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord