Design comparison
Solution retrospective
Not a great one. Did a lot of unnecessary stuff and kind of lost track. Couldn't make it responsive for mobile. Any kind of help or feedback is welcome. Thanks!
Community feedback
- @amalkarimPosted about 2 years ago
Hi David 👋,
I think your solution is a great one. It also looks quite nice on mobile screen, to be honest. I don't see big problems in it. About
kinda lost track
, well, we do experience it sometimes. The important thing is you finished and submitted the solution.However, allow me to give some tiny suggestions (about the details) to your solution.
- Add some
padding
s to thebody
to give a nice white space around the content, especially when the user's browser height is less than the content height. Also, addingmargin-bottom
to.container
would be nice. - In
.mainImage
, instead ofbackground-size; auto 100%;
, you could do this instead to make its size not too big but still centered:
background-size: auto; background-repeat: no-repeat; background-position: center center;
- Adding
align-items: center;
to.ethColor
and.timeColor
will prevent those two icons being squeezed in a small screen size.
If you still have problems, feel free to reply to this comment.
Hope this helps. Happy coding!
Marked as helpful1@davidicabelloPosted about 2 years ago@amalkarim Thank you very much foe the tips! I will implement them as soon as i can !
0 - Add some
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord