NFT preview card component

Community feedback

• 

  Adriano•38,080

  @AdrianoEscarabotePosted almost 2 years ago

  Hello VladoNo1, how are you? I truly loved your project's outcome, however I have some advice that I hope you'll find useful:

  To remove the scrollbar we can do this:

  body {
      /* margin: 2rem; */
      padding: 2rem;
  }
  

  You could have used a h1 to make the project more accessible. Every page must have a level 1 header that identifies the primary title and follows the h1-h5 format for screen readers.

  <h1><a class="title" href="#">Equilibrium #3429</a></h1>

  The remainder is excellent.

  I hope it's useful. 👍

  Marked as helpful

  1
• 

  Travolgi 🍕•31,400

  @denieldenPosted almost 2 years ago

  Hello Vlado, You have done a good work! 😁

  Some little tips to improve your code:

  • add descriptive text in the alt attribute of the images
  • use min-height: 100vh to body instead of height, otherwise the content is cut off when the browser height is less than the content
  • Using <hr> for the line is not the best way because this tag have a semantic meaning... in this case use div with border-bottom because this line is decorative
  • add transition on the element with hover effect
  • instead of using px use relative units of measurement like rem -> read here

  Keep learning how to code with your amazing solutions to challenges.

  Hope this help 😉 and Happy coding!

  Marked as helpful

  1